kmesh icon indicating copy to clipboard operation
kmesh copied to clipboard

backend_manager can return 1 from tail call, so check negative value

Open hzxuzhonghu opened this issue 1 year ago • 2 comments

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes: Fix https://github.com/kmesh-net/kmesh/issues/355

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


hzxuzhonghu avatar May 23 '24 11:05 hzxuzhonghu

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from hzxuzhonghu. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kmesh-bot avatar May 23 '24 11:05 kmesh-bot

Wa are not sure how the 1 was returned, and could not reproduce with latest code

hzxuzhonghu avatar May 28 '24 07:05 hzxuzhonghu

didnot see again, this was likely to be caused by invalid mem access

hzxuzhonghu avatar Sep 29 '24 07:09 hzxuzhonghu