kmesh icon indicating copy to clipboard operation
kmesh copied to clipboard

[clean] only install istiod when kmesh run e2e test

Open LiZhenCheng9527 opened this issue 1 month ago • 2 comments

What type of PR is this? /kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


LiZhenCheng9527 avatar Nov 15 '25 08:11 LiZhenCheng9527

Summary of Changes

Hello @LiZhenCheng9527, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the Istio installation process within the Kmesh end-to-end test suite. The primary goal is to streamline the test environment setup by transitioning from istioctl to helm for deploying Istio components, ensuring that only necessary parts like istiod are installed and properly initialized. This change aims to make the e2e tests more efficient and reliable by providing a more controlled and explicit Istio deployment.

Highlights

  • Istio Installation Method Change: The method for installing Istio components in the e2e test environment has been updated, transitioning from using istioctl to helm for deployment.
  • Explicit Istiod Readiness Check: A new mechanism has been introduced to explicitly wait for the istiod pod to reach a 'Running' state before proceeding with further test setup, enhancing test reliability.
  • Streamlined Istio Setup: The setup_istio function now focuses specifically on installing istiod with ambient mode enabled, removing previous configurations for gateway-api CRDs and ingress gateways, aligning with a more targeted test environment.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


Helm charts now deploy, Istiod waits, running free, Tests run smooth and fast.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

gemini-code-assist[bot] avatar Nov 15 '25 09:11 gemini-code-assist[bot]

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 37.84%. Comparing base (3af835f) to head (fe941b3). :warning: Report is 6 commits behind head on main. see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 18ccbeb...fe941b3. Read the comment docs.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Nov 18 '25 03:11 codecov[bot]

Our document should also be updated

hzxuzhonghu avatar Nov 19 '25 09:11 hzxuzhonghu

/lgtm /approve

hzxuzhonghu avatar Nov 19 '25 09:11 hzxuzhonghu

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kmesh-bot avatar Nov 19 '25 09:11 kmesh-bot