kmesh icon indicating copy to clipboard operation
kmesh copied to clipboard

prevent deletion of addresses that are already occupied by other objects

Open YaoZengzeng opened this issue 7 months ago • 2 comments

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes: Fixes #1352

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


YaoZengzeng avatar Apr 30 '25 08:04 YaoZengzeng

Codecov Report

Attention: Patch coverage is 88.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 46.38%. Comparing base (1efb096) to head (82e0dce). Report is 36 commits behind head on main.

Files with missing lines Patch % Lines
pkg/controller/workload/cache/service_cache.go 82.35% 2 Missing and 1 partial :warning:
Files with missing lines Coverage Δ
pkg/controller/workload/cache/workload_cache.go 69.35% <100.00%> (+3.90%) :arrow_up:
pkg/controller/workload/cache/service_cache.go 79.24% <82.35%> (+54.24%) :arrow_up:

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 09d3fdc...82e0dce. Read the comment docs.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Apr 30 '25 08:04 codecov[bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kmesh-bot avatar May 06 '25 08:05 kmesh-bot