kmesh icon indicating copy to clipboard operation
kmesh copied to clipboard

remove BpfLoader.KmeshConfig to prevent writing using it, should alwa…

Open hzxuzhonghu opened this issue 7 months ago • 3 comments

…ys use the method provided

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes: Fixes https://github.com/kmesh-net/kmesh/issues/1344

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


hzxuzhonghu avatar Apr 28 '25 12:04 hzxuzhonghu

Codecov Report

Attention: Patch coverage is 43.39623% with 30 lines in your changes missing coverage. Please review.

Project coverage is 45.68%. Comparing base (a1e0bd3) to head (5a0730b). Report is 34 commits behind head on main.

Files with missing lines Patch % Lines
pkg/bpf/bpf.go 43.39% 15 Missing and 15 partials :warning:
Files with missing lines Coverage Δ
pkg/bpf/bpf.go 41.08% <43.39%> (-0.37%) :arrow_down:

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1844e9e...5a0730b. Read the comment docs.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Apr 29 '25 01:04 codecov[bot]

/retest

hzxuzhonghu avatar Apr 29 '25 02:04 hzxuzhonghu

@nlgwcy @LiZhenCheng9527

hzxuzhonghu avatar May 06 '25 08:05 hzxuzhonghu

/lgtm /approve

LiZhenCheng9527 avatar May 06 '25 08:05 LiZhenCheng9527

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LiZhenCheng9527

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kmesh-bot avatar May 06 '25 08:05 kmesh-bot