kmesh icon indicating copy to clipboard operation
kmesh copied to clipboard
verified publisher icon kmesh-net

bash format added in make format

Open yp969803 opened this issue 7 months ago • 11 comments

What type of PR is this?

/kind enhancement

What this PR does / why we need it: bash format added in make format

Which issue(s) this PR fixes: Fixes #1328

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

yp969803 avatar Apr 23 '25 06:04 yp969803

@hzxuzhonghu waiting for review !!

yp969803 avatar Apr 23 '25 06:04 yp969803

/retest

yp969803 avatar Apr 23 '25 06:04 yp969803

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 45.86%. Comparing base (a1e0bd3) to head (36330a2). Report is 16 commits behind head on main.

see 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1844e9e...36330a2. Read the comment docs.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Apr 23 '25 06:04 codecov[bot]

Do you use https://github.com/mvdan/sh?

hzxuzhonghu avatar Apr 23 '25 08:04 hzxuzhonghu

yes

yp969803 avatar Apr 23 '25 09:04 yp969803

shfmt package is not available in yum , I think I have to use go

yp969803 avatar Apr 23 '25 09:04 yp969803

@hzxuzhonghu can u see now

yp969803 avatar Apr 23 '25 09:04 yp969803

Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository. Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kmesh-bot avatar Apr 29 '25 04:04 kmesh-bot

@hzxuzhonghu done the changes

yp969803 avatar Apr 29 '25 04:04 yp969803

@hzxuzhonghu waiting for merge !!

yp969803 avatar May 01 '25 07:05 yp969803

/approve

sorry missed this label

hzxuzhonghu avatar May 06 '25 01:05 hzxuzhonghu

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kmesh-bot avatar May 06 '25 01:05 kmesh-bot