kmesh icon indicating copy to clipboard operation
kmesh copied to clipboard

feat(authz): Add E2E test for kmeshctl authz functionality

Open ravjot07 opened this issue 10 months ago • 9 comments

  • Implement end-to-end test for kmeshctl authz commands (enable, status, disable)
  • Automatically retrieves a running Kmesh Daemon pod using kubectl
  • Verifies:
    • Enabling authz (kmeshctl authz enable <pod>)
    • Checking authz status (kmeshctl authz status <pod>)
    • Disabling authz (kmeshctl authz disable <pod>)
    • Ensuring correct output (true/enabled or false/disabled)
  • Adds retry mechanism to ensure pod readiness before executing tests

This enhances test coverage for Kmesh authz offloading and ensures functionality works on a live cluster.

Contributes towards: #991

ravjot07 avatar Feb 17 '25 01:02 ravjot07

Also make sure you pass the test case you have wrote, as well as the rest of the CI.

YaoZengzeng avatar Feb 17 '25 01:02 YaoZengzeng

Also make sure you pass the test case you have wrote, as well as the rest of the CI.

Yup, actually ci issues was with the previous pr it will be fixed once other pr got merged..

ravjot07 avatar Feb 17 '25 01:02 ravjot07

Also make sure you pass the test case you have wrote, as well as the rest of the CI.

I will trying to get hold of this e2e testing and other stuff required for this project, could you guide me through some more resources it will really helpful for me to work with this e2e thing once I got more comfortable in this part

ravjot07 avatar Feb 17 '25 01:02 ravjot07

Also make sure you pass the test case you have wrote, as well as the rest of the CI.

I will trying to get hold of this e2e testing and other stuff required for this project, could you guide me through some more resources it will really helpful for me to work with this e2e thing once I got more comfortable in this part

https://github.com/kmesh-net/kmesh/issues/1210#issuecomment-2658474077 These are all the resources now. If you are selected by LFX, you can help to further improve these.

Now you can ask questions directly under this PR :)

YaoZengzeng avatar Feb 17 '25 02:02 YaoZengzeng

friendly ping @ravjot07

YaoZengzeng avatar Mar 14 '25 06:03 YaoZengzeng

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign yaozengzeng for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kmesh-bot avatar Mar 19 '25 03:03 kmesh-bot

https://github.com/kmesh-net/kmesh/pull/641/files#diff-653de079078723797aee35a7aa1238cb15349038e7bbf3eadd47a04e96847811

@ravjot07 you can refer to this of how to install kmeshctl in E2E

YaoZengzeng avatar Mar 20 '25 06:03 YaoZengzeng

https://github.com/kmesh-net/kmesh/pull/641/files#diff-653de079078723797aee35a7aa1238cb15349038e7bbf3eadd47a04e96847811

@ravjot07 you can refer to this of how to install kmeshctl in E2E

I was kinda stuck, @YaoZengzeng this will surely help me

ravjot07 avatar Mar 20 '25 06:03 ravjot07

https://github.com/kmesh-net/kmesh/pull/641/files#diff-653de079078723797aee35a7aa1238cb15349038e7bbf3eadd47a04e96847811 @ravjot07 you can refer to this of how to install kmeshctl in E2E

I was kinda stuck, @YaoZengzeng this will surely help me

It's fine to ask for help, either in slack of directly in the PR :)

YaoZengzeng avatar Mar 20 '25 06:03 YaoZengzeng