kmesh icon indicating copy to clipboard operation
kmesh copied to clipboard

implemented e2e test on log

Open harshitghagre opened this issue 10 months ago • 3 comments

What type of PR is this? /kind enhancement

What this PR does: e2e test for the log package

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer: Does this PR introduce a user-facing change?:

harshitghagre avatar Feb 14 '25 09:02 harshitghagre

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign yaozengzeng for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kmesh-bot avatar Feb 14 '25 09:02 kmesh-bot

@YaoZengzeng I have made the changes you asked for

harshitghagre avatar Feb 15 '25 11:02 harshitghagre

@harshitghagre you should pass the test case you have wrote, as well as the rest of the CI.

YaoZengzeng avatar Feb 17 '25 01:02 YaoZengzeng