kmesh icon indicating copy to clipboard operation
kmesh copied to clipboard

Fix CI: Regenerate docs for authz subcommands

Open ravjot07 opened this issue 10 months ago • 7 comments

Fix ci issues in #1217

ravjot07 avatar Feb 09 '25 12:02 ravjot07

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign supercharge-xsy for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kmesh-bot avatar Feb 09 '25 12:02 kmesh-bot

gen check failed

hzxuzhonghu avatar Feb 10 '25 02:02 hzxuzhonghu

gen check failed

Hey, can u guide me in right direction why these checks are failing

ravjot07 avatar Feb 10 '25 09:02 ravjot07

related to, the CI use clang format. I think you can revert these white spaces added around &

-#define SET_RET_MSG_TYPE(n, type) (n) = (((n) & 0xff) | (((u32)(type) & 0xff) << KMESH_PROTO_TYPE_WIDTH))
+#define SET_RET_MSG_TYPE(n, type) (n) = (((n)&0xff) | (((u32)(type)&0xff) << KMESH_PROTO_TYPE_WIDTH))

hzxuzhonghu avatar Feb 11 '25 01:02 hzxuzhonghu

related to, the CI use clang format. I think you can revert these white spaces added around &

-#define SET_RET_MSG_TYPE(n, type) (n) = (((n) & 0xff) | (((u32)(type) & 0xff) << KMESH_PROTO_TYPE_WIDTH))
+#define SET_RET_MSG_TYPE(n, type) (n) = (((n)&0xff) | (((u32)(type)&0xff) << KMESH_PROTO_TYPE_WIDTH))

ok @hzxuzhonghu i will try this once

ravjot07 avatar Feb 13 '25 10:02 ravjot07

please update

hzxuzhonghu avatar Feb 17 '25 01:02 hzxuzhonghu

This has been modified #1241

LiZhenCheng9527 avatar Feb 22 '25 02:02 LiZhenCheng9527