kmesh icon indicating copy to clipboard operation
kmesh copied to clipboard

Added changes to generated api file under same package

Open 7h3-3mp7y-m4n opened this issue 10 months ago • 4 comments

What type of PR is this?

Added changes to Makefile to make protobuf generated api file under same package with .proto

/kind bug

What this PR does / why we need it: This add nessacry change to Makefile to generate the file inside the same directory using protoc --proto_path=. --go_out=. --go_opt=paths=source_relative workloadapi/workload.proto Which issue(s) this PR fixes: Fixes #1024

Special notes for your reviewer: checking to CI because of arm64

7h3-3mp7y-m4n avatar Feb 06 '25 19:02 7h3-3mp7y-m4n

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign bitcoffeeiux for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kmesh-bot avatar Feb 06 '25 19:02 kmesh-bot

Welcome @7h3-3mp7y-m4n! It looks like this is your first PR to kmesh-net/kmesh 🎉

kmesh-bot avatar Feb 06 '25 19:02 kmesh-bot

I can run make gen-proto successfully in my AMD64 env.

But it is expected workload.pb.go to be in api/workloadapi/workload.pb.go instead of api/workloadapi/workloadapi/workload.pb.go

hzxuzhonghu avatar Feb 07 '25 02:02 hzxuzhonghu

BTW, you can make other protobuf behave same

hzxuzhonghu avatar Feb 07 '25 02:02 hzxuzhonghu