kmesh icon indicating copy to clipboard operation
kmesh copied to clipboard

Fix: `make build` should build kmeshctl

Open adwait-godbole opened this issue 10 months ago • 5 comments

Fixes #1113

/kind bug

NONE

adwait-godbole avatar Jan 29 '25 18:01 adwait-godbole

@adwait-godbole: The label(s) kind/documentation cannot be applied, because the repository doesn't have them.

In response to this:

Fixes #1113

/kind bug /kind enhancement /kind documentation

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kmesh-bot avatar Jan 29 '25 18:01 kmesh-bot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign kevin-wangzefeng for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kmesh-bot avatar Jan 29 '25 18:01 kmesh-bot

Welcome @adwait-godbole! It looks like this is your first PR to kmesh-net/kmesh 🎉

kmesh-bot avatar Jan 29 '25 18:01 kmesh-bot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (main@114428f). Learn more about missing BASE report. Report is 250 commits behind head on main.

Files with missing lines Coverage Δ
pkg/nets/nets.go 23.93% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 114428f...a698491. Read the comment docs.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Jan 29 '25 19:01 codecov[bot]

@adwait-godbole can you please update

hzxuzhonghu avatar May 13 '25 01:05 hzxuzhonghu