kmesh icon indicating copy to clipboard operation
kmesh copied to clipboard

Fix test maglev test suite

Open hzxuzhonghu opened this issue 11 months ago • 3 comments

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes: Fixes https://github.com/kmesh-net/kmesh/issues/1137

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


hzxuzhonghu avatar Dec 24 '24 09:12 hzxuzhonghu

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from hzxuzhonghu. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kmesh-bot avatar Dec 24 '24 09:12 kmesh-bot

Codecov Report

Attention: Patch coverage is 76.74419% with 10 lines in your changes missing coverage. Please review.

Project coverage is 51.83%. Comparing base (8197d65) to head (cd55a9b). Report is 154 commits behind head on main.

Files with missing lines Patch % Lines
pkg/consistenthash/maglev/maglev.go 82.85% 4 Missing and 2 partials :warning:
pkg/cache/v2/cluster.go 50.00% 3 Missing and 1 partial :warning:
Files with missing lines Coverage Δ
pkg/bpf/ads/loader.go 38.02% <ø> (+1.54%) :arrow_up:
pkg/bpf/ads/sock_connection.go 55.46% <ø> (ø)
pkg/cache/v2/cluster.go 43.87% <50.00%> (+0.62%) :arrow_up:
pkg/consistenthash/maglev/maglev.go 70.00% <82.85%> (+1.34%) :arrow_up:

... and 13 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f4104f3...cd55a9b. Read the comment docs.

codecov[bot] avatar Dec 24 '24 09:12 codecov[bot]

TestKmeshRestart falke

/retest

hzxuzhonghu avatar Jan 16 '25 01:01 hzxuzhonghu