Klaus Post

Results 349 comments of Klaus Post

It can either be faster or compresses more and sometimes both. https://github.com/klauspost/compress/tree/master/s2#snappy-compatibility Replace `snappylib "github.com/golang/snappy"` -> `github.com/klauspost/compress/s2`. If you don't want options `snappylib github.com/klauspost/compress/snappy`. ``` c.poolCompressor.New = func() interface{} {...

Yeah, adding it as a separate option would be nice (and trivial) FWIW here is a comparison of different types: https://twitter.com/sh0dan/status/1532298056082804736

@mostynb You can do that either way. It does not keep goroutines active.

I can confirm this fixes the issue on 1.17.6 windows/amd64

I tried out your patch, and things still stops processing, but quite randomly. However the more workers I run, the more likely it seems to be that there is a...

@ThorbjoernSchulz ``` go get -u github.com/klauspost/simdjson-fuzz go get -u github.com/fwessels/simdjson-go cd $GOPATH$/src/github.com/klauspost/simdjson-fuzz go-fuzz-build -o=fuzz-build.zip -func=Fuzz . go-fuzz -minimize=5s -bin=fuzz-build.zip -workdir=corpus -procs=16 ``` Using verbose output it ends up with something...

https://github.com/pquerna/ffjson/blob/master/inception/encoder.go#L110 Pretty sure it is needed though. Probably for this https://github.com/pquerna/ffjson/blob/master/inception/encoder.go#L117

We need a complete reproduction case, since we don't have anything to go by. In the sample there is no indication what "body" really is. It seems like a crash...

The package uses the "UnmarshalText" interface instead of the "UnmarshalJSON". This is not picked up by ffjson. Not sure why the fallback doesn't handle this gracefully though.

"much slower" is rather an overstatement. First of all use real-world data, a single string isn't going to tell you much. Also, I don't think the ffjson code is actually...