kjdev

Results 61 comments of kjdev

I have confirmed that ob_brotli_handler causes an error and would like to fix it.

What would be the case that it does not work properly? ``` php

https://github.com/kjdev/php-ext-brotli/compare/master...develop Is a correction like this sufficient?

Is this correct? https://github.com/kjdev/php-ext-brotli/commit/5e9353e67e515c12a3f6c2795b51391d2e86e5a5 ``` c while (available_in || BrotliEncoderHasMoreOutput(ctx->encoder)) { if (BrotliEncoderCompressStream(ctx->encoder, .. } if (mode == BROTLI_OPERATION_FINISH) { while (!BrotliEncoderIsFinished(ctx->encoder)) { if (BrotliEncoderCompressStream(ctx->encoder, .. } } ```

https://github.com/kjdev/php-ext-brotli/commit/0fefb0ef3f8344c7f3c290158537858d050ba3e2 ``` TEST 4/28 [tests/compress_add.phpt] PASS Test brotli_compress_add() functionality [tests/compress_add.phpt] ``` The test will pass, so we will make adjustments based on this code.

No blockers/questions so far We will respond quickly

Fixed (master branch) A modified PECL version will be released later

libtool is not managed in this repository. libtool is not needed for execution and may be removed. Only snappy.so is needed. For example, how to. - Remove build tools ```...

So it's an option, but the Redis store isn't enabled. I wonder if it would be easier to use the Redis store if it is enabled, since it may be...

Redis uses a key that combines the zone name and key name. (`{zone}:{key}`) ``` sh redis-cli SET handler:disabled 1 ```