Kai
Kai
@ghbren Ready for review, but shouldn't be merged until after #269 (if you want to merge this changeset first, I can update the PRs). I've removed all the SARIF bits...
Rebased against master.
Rebased and removed some emails.
There have been a few changes to `gitleaks` since I last looked at it. I'm going to take a closer look on Monday & I'll give you a ping once...
@ghbren Tests should be all fixed now. > There are a bunch of binary files in this PR. What are these? Should they be removed? I've embedded a git repo...
Afaik, the full repo is required to test the commit-scanning functionality. If we remove those tests, then it would be sufficient to just have some files with secrets.
Yup - gitleaks scans commit objects inside a Git repo. If you want to verify the contents of the commit files, you can rename the `dotGit` directory to `.git` and...
* Rebased against master (kept Golang at 1.15.11) * Reverted change to `remove_key`
> There are 10+ binary files in the PR. Are all of them needed to test the commit scanning feature? I haven't exhaustively tested them all, but I confirmed that...
I've been following along the convo in #131 and I think a better solution (albeit breaking change) would be to: - _Default_ to printing output with a newline instead of...