kiwix-js
kiwix-js copied to clipboard
Publish the docker image used to compile libzim with emscripten
In some docker registry. So that it's ready-to-use for developers on kiwix-js, without forcing them to build the image
@mossroy Not sure to understand the rationals behind this ticket? Why such a Docker image shoukd be necessary if https://github.com/kiwix/kiwix-build/issues/503 is inplemented?
That depends on how far we go on integrating the emscripten build(s) in kiwix-build. The first step is libzim itself, with https://github.com/kiwix/kiwix-build/issues/503 If we only do this first step, there will still be a second emscripten compilation step to be done on the C "glue" code that allows to call libzim from javascript. In this case, it might be relevant to share one docker image for both compilation steps.
But if we go further and implement https://github.com/kiwix/kiwix-js/issues/768 to do all the emscripten compilation in kiwix-build, I agree with you it might not be necessary to share the docker image
To sum up, I think that depends on how much we integrate build steps on kiwix-build In all cases, it should not be considered as a blocker: it's always possible to re-build the docker image when it's needed
@mossroy I will discuss this with @mgautierfr, but to me the goal is clearly that libzim is directly usable in Javascript.
I guess this ticket should ne now mode to openzim/javascript-libzim?
I guess this ticket should ne now mode to
openzim/javascript-libzim?
Yes (but I don't seem to be able to do that with the "Transfer issue" link of github)
@mossroy done with Kamino https://github.com/gatewayapps/kamino
Well, it indeed copy/pasted the issue and its comments, but it also changed the order of comments, and lost the author/date of each comment. It makes it really hard to understand without referring to the original ticket (here)