kiwix-js icon indicating copy to clipboard operation
kiwix-js copied to clipboard

Provide a bookmarking system like in Kiwix Desktop

Open Jaifroid opened this issue 4 years ago • 8 comments

As suggested by @knowledge-is-power here, it would be good to have a bookmark system in Kiwix JS and Kiwix JS PWA/Windows. It would require #280 or similar, and probably also depends on #656 to allow seamless switching between bookmarks in different ZIM archives in a folder (to which the user has given read permission).

Jaifroid avatar Aug 25 '21 07:08 Jaifroid

This should simply work through the Web Browser bookmarking system. Would be a bad idea IMO to redo something special here.

kelson42 avatar Aug 25 '21 07:08 kelson42

This should simply work through the Web Browser bookmarking system. Would be a bad idea IMO to redo something special here.

Agreed in principle, but unfortunately it doesn't work even in Service Worker mode. So we need to make it work, probably with #280. Even so, that would only work in Service Worker mode, which Firefox browser-extension users can't access. Plus there are other contexts where the browser's native bookmarking system is not available: PWA, mobile. Another solution is needed for these. That solution should be as close to the native browser system as possible, and should leverage its APIs where they are available.

Jaifroid avatar Aug 25 '21 07:08 Jaifroid

I would recommend to really try to secure we have proper URLs - which is I guess the main problem to get this working with the browser bookmark system. Then re-evaluate how important is that to provide a bookmark system for other use cases. Developing a simple bookmarking system is easy, but having a compeeting feature here will need a lot of work...

kelson42 avatar Aug 25 '21 08:08 kelson42