nova-inline-relationship icon indicating copy to clipboard operation
nova-inline-relationship copied to clipboard

Labels shows as array

Open nemrutco opened this issue 5 years ago • 42 comments
trafficstars

When i use it with BelongsTo relationship, labels are becomes like :

profile[0][id_number] - profile[0][name] ... etc.

nemrutco avatar Jan 16 '20 07:01 nemrutco

Seems like it's related to Nova's 2.9.3 update, Nova will now use the give field name first for determining a field's label.. #764

nemrutco avatar Jan 16 '20 08:01 nemrutco

@nemrutco Thanks for this info. We'll look into it, but in the meantime feel free to submit a PR for this issue. We enjoy working with the community!

brandonferens avatar Jan 16 '20 14:01 brandonferens

The same problem on create form:

image

4n70w4 avatar Jan 28 '20 15:01 4n70w4

Also experiencing the same issue with Nova 2.10.1

kculmback avatar Feb 16 '20 04:02 kculmback

Also experiencing the same issue with Nova 2.11.1

And really nice package by the way - really should make it into the core.

Dixens avatar Mar 02 '20 08:03 Dixens

I have the same problem with HasMany relation.

david-kristin avatar Mar 03 '20 17:03 david-kristin

Same issue with Nova 2.12.0

drewwbctz avatar Mar 03 '20 20:03 drewwbctz

OK now, even with Nova 2.11.1. Thanks.

Dixens avatar Mar 09 '20 14:03 Dixens

I just wasted an hour trying to make this work (I had to figure out how to refresh the compiled files), but it seems there's a fix already

https://github.com/kirschbaum-development/nova-inline-relationship/commit/1d9d4872575a6569efda1375cbff6e9da3074aeb

genesiscz avatar Mar 19 '20 03:03 genesiscz

here's how I applied this in my project (maybe unsafe):

composer.json:

        "kirschbaum-development/nova-inline-relationship": "dev-master#1d9d4872575a6569efda1375cbff6e9da3074aeb",


or maybe

composer require "kirschbaum-development/nova-inline-relationship=dev-master#1d9d4872575a6569efda1375cbff6e9da3074aeb"
composer install
cd vendor/kirschbaum-development/nova-inline-relationship
npm i
npm run watch
rm -rf node_modules/

done

genesiscz avatar Mar 19 '20 03:03 genesiscz

Maybe is missing a tag release?

skoyah avatar Mar 31 '20 10:03 skoyah

OK now, even with Nova 2.11.1. Thanks.

Back to labels as arrays for some reason (no update).

Dixens avatar Apr 29 '20 11:04 Dixens

Any idea when this will be pushed to packagist?

gshzn avatar May 05 '20 08:05 gshzn

I can confirm this issue.

cch504 avatar May 05 '20 20:05 cch504

Any updates or workarounds for this issue?

mauricewaney avatar May 22 '20 09:05 mauricewaney

here's how I applied this in my project (maybe unsafe):

composer.json:

        "kirschbaum-development/nova-inline-relationship": "dev-master#1d9d4872575a6569efda1375cbff6e9da3074aeb",

npm install
cd vendor/kirschbaum-development/nova-inline-relationship
npm i
npm run watch
rm -rf node_modules/

done

Try this

genesiscz avatar May 23 '20 16:05 genesiscz

Hello, I just tried the solution abose, but still see the labels as articles[0][title] Thank you

vwasteels avatar Jun 25 '20 13:06 vwasteels

oh it's composer update instead of npm install :

in composer.json:
"kirschbaum-development/nova-inline-relationship": "dev-master#1d9d4872575a6569efda1375cbff6e9da3074aeb",

composer install
cd vendor/kirschbaum-development/nova-inline-relationship
npm i
npm run prod
rm -rf node_modules/

vwasteels avatar Jun 25 '20 13:06 vwasteels

ah yeah sorry for that

genesiscz avatar Jun 27 '20 04:06 genesiscz

@kirschbaum do you plan to integrate this fix into a future release ?

vwasteels avatar Jun 29 '20 13:06 vwasteels

@kirschbaum Just poking this issue once more to try and get a new release if this is in fact already fixed?

ragingdave avatar Jul 13 '20 16:07 ragingdave

@kirschbaum Is this repo abandoned? Any help?

Milkhan avatar Jul 26 '20 17:07 Milkhan

@brandonferens any chance to get a new release?

NioTeX avatar Aug 31 '20 13:08 NioTeX

I forked a forked repo of this repo and compiled the files to make it work out of the box - feel free to add

"repositories": [

        {
            "type": "vcs",
            "url": "https://github.com/genesiscz/nova-inline-relationship"
        }
]

to your composer json and then composer require kirschbaum-development/nova-inline-relationship

genesiscz avatar Sep 01 '20 14:09 genesiscz

@genesiscz I tried to use your fork, but my HasOne inline now complains about "Too few arguments to function Laravel\Nova\Fields\HasOne::KirschbaumDevelopment\NovaInlineRelationship\{closure}(), 0 passed and exactly 1 expected",

jberculo avatar Sep 09 '20 13:09 jberculo

@kirschbaum @brandonferens any updates here or is this repo abandoned? There has been no updates/comments from you guys for quite some time, and nothing has happened in this repo for coming up on 6 months. This package is currently broken for Nova v2/3 so basically anyone wanting to use it are currently SOL without maintaining their own fork.

ragingdave avatar Sep 09 '20 16:09 ragingdave

@ragingdave we'd love to work on this more. There are two issues: 1) we're extremely busy at the moment and haven't had time to focus on this yet and b) there are some major issues with how this package needed to be created. It's been making fixing bugs and keeping the package updated very challenging.

If anyone is interested in helping to take these issues on let me know and we can have a quick call with you to discuss. These issues are quite complex and require deep understanding of Laravel and Nova. Would love to see this project move forward and succeed.

kirschbaum avatar Sep 09 '20 17:09 kirschbaum

@kirschbaum I would be interested in helping, as the end result of this package is something that would be very useful to me and my team and I'm sure, based on previous comments, others as well.

ragingdave avatar Sep 09 '20 17:09 ragingdave

@genesiscz I tried to use your fork, but my HasOne inline now complains about "Too few arguments to function Laravel\Nova\Fields\HasOne::KirschbaumDevelopment\NovaInlineRelationship{closure}(), 0 passed and exactly 1 expected",

Pass a $request to the inline()

genesiscz avatar Sep 09 '20 21:09 genesiscz

@ragingdave I have sent you an email invite for us all to sync. Let me know if you didn't get it.

kirschbaum avatar Sep 10 '20 14:09 kirschbaum