Kirk Bushell
Kirk Bushell
This is excellent. Will test it out when I get home.
There's some comments in some of the code that can be removed - and please write tests for the new features.
@neon64 ping!
Firstly - Laravel 5.1 will be 5.5+. Secondly, we use it throughout our tests and the package on the whole (check the service provider) so saying we don't use it...
It's mostly just syntactical sugar, but it does help when things change/get refactored. I'll chat with mitch tomorrow - though we've already had this chat before and wanted to move...
@jasonlfunk I'll chat with Mitch - there's plenty of reason to support PHP 5.4. We'll have another chat about it - you're not the only the only one to have...
This needs an update - it will break when the entity object is passed, so it should cater for both scenarios. If you could update it to include that, then...
Not sure - but this change breaks the package :) If you can fix that up, we're good to go.
@acairns not sure, tbh I checked this out a couple of weeks ago and it was breaking then - which was the reason for the original comment.
If tests can be written to manage all the changes, then we can move forward with the implementation / merge.