go-d3d icon indicating copy to clipboard operation
go-d3d copied to clipboard

Make BGRA conversion optional

Open merlinaudio opened this issue 2 years ago • 2 comments

When encoding with e.g. ffmpeg, ffmpeg can handle the conversion, right? It'd be great if we could disable the conversion to RGBA.

Maybe it'd make sense to remove it from the library completely, because if someone wants to convert BGRA -> RGBA, it's just one line to add?

Just throwing around a couple ideas :)

Many thanks for building this lib!

merlinaudio avatar Dec 29 '22 00:12 merlinaudio

i just remembered that BGRA<->RGBA is done automatically on "modern" Windows, if IDXGIOutput5::DuplicateOutput1 is used with the requested image format.

i'd like to close this issue, as most shouldn't need to worry about this.

kirides avatar Feb 14 '23 17:02 kirides

with microsoft deprecating more and more windows versions, i might not even go so far to disable the BGRA conversion, but rather allow the consumer to specify their own compatible format to let windows do the work (or non)

kirides avatar Feb 23 '23 18:02 kirides