containerise icon indicating copy to clipboard operation
containerise copied to clipboard

Add ability to ignore tabs (to prevent infinite loops)

Open KnightTim opened this issue 6 years ago • 6 comments

If you use a container add-on like Mozilla's Facebook Container or one of the many forks, this add-on will fight with it. The tab will open and close infinitely.

To reproduce this:

  • Install this add-on and facebook container
  • In settings for this add-on enable "Default container"
  • Disable "Keep old tabs" (if you leave it enabled it will open infinite tabs)
  • Open a new tab and navigate to Facebook.com
  • Containerise will try to place the default container and the other add-on will try to place it in it's container.

You can fix this by adding all the same rules to containerise, but it is harder to add certain rules. For example the google container has the option to not load google search pages in the google container. More complicated rules like that seem difficult to emulate in containerise.

I suggest that a good way to fix this is allow the user to have another option, like the "No container" option. Create an "Ignored tabs", allow the user to put domains and regex which containerise will use to not act on any matching tabs.

KnightTim avatar Nov 08 '19 14:11 KnightTim

:+1:

Hout avatar Dec 13 '19 22:12 Hout

I suggest that a good way to fix this is allow the user to have another option, like the "No container" option. Create an "Ignored tabs", allow the user to put domains and regex which containerise will use to not act on any matching tabs.

I feel like I'm missing something here. Isn't that just the equivalent of not adding those rules to containerise?

LoveIsGrief avatar Dec 23 '19 17:12 LoveIsGrief

If you enable "Default Container" every tab you open is acted on. Even tabs that have no rules.

KnightTim avatar Dec 23 '19 18:12 KnightTim

Ah, that's what I missed.

LoveIsGrief avatar Dec 23 '19 18:12 LoveIsGrief

Any updates on this? :)

freewill404 avatar Jan 15 '20 14:01 freewill404

I'm working on other projects, but PRs are welcome

LoveIsGrief avatar Jan 15 '20 15:01 LoveIsGrief