django-squash icon indicating copy to clipboard operation
django-squash copied to clipboard

Published 20 hours ago • verified publisher icon kingbuzzman

`rename_migrations` can fail if migration name does not start with 4 ints

Open breid1313 opened this issue 1 year ago • 5 comments

we have a migration named like 02_some_name. probably bad form, but this package should be resilient to that. I can submit a PR to address this shortly.

breid1313 avatar Jan 12 '24 17:01 breid1313

Hello, and thank you for submitting the pull request.

This matter should be addressed directly with Django. The capability to make such changes is granted by Django itself, and it's not a feature that this library facilitates. Unless this file is causing a bug that affects the generation or reading of migrations, I regret to inform you that this is considered an invalid change.

kingbuzzman avatar Jan 16 '24 09:01 kingbuzzman

Legitimate bug, fixed in #18

kingbuzzman avatar Jan 22 '24 14:01 kingbuzzman

@breid1313 can you check if #18 fixes your issue?

kingbuzzman avatar Jan 23 '24 11:01 kingbuzzman

PR has been merged, version has been bumped. Let me know if this solved it.

kingbuzzman avatar Jan 24 '24 18:01 kingbuzzman

@breid1313?

kingbuzzman avatar Jan 30 '24 13:01 kingbuzzman

If this becomes an issue again, feel free to reopen it.

kingbuzzman avatar Mar 05 '24 21:03 kingbuzzman