blockchain-load-testing icon indicating copy to clipboard operation
blockchain-load-testing copied to clipboard

add whitelist support to load testing

Open oryband opened this issue 6 years ago • 8 comments

also:

  • adapt test enviornment and automation scripts for new whitelist load test feature
  • migrate from glide to go dep
  • migrate from stellar/go to kinecosystem/go and pin version
  • minor documentation and cosmetic code updates

oryband avatar Aug 21 '19 14:08 oryband

I don't understand the whitelist command. What is it for?

avi-kik avatar Aug 21 '19 14:08 avi-kik

I don't understand the whitelist command. What is it for?

@avi-kik it adds an address to the whitelist. It is meant to be run once per test as part of the setup, before we start the load test app, just like we create test accounts before starting the load test app.

oryband avatar Aug 21 '19 14:08 oryband

Such a command is not necessary for testing.

  1. the whitelist account holder (configured in stellar-core.cfg) is a whitelisted account.
  2. the whitelist account holder doesn't need to exist on the blockchain. It works by virtue of being defined as the holder.

avi-kik avatar Aug 21 '19 14:08 avi-kik

@avi-kik this app doesn't create account at all, it just adds a list of addresses to the whitelist. It lets you control which addresses are whitelisted or not.

oryband avatar Aug 21 '19 14:08 oryband

This will be useful when we have multi-level priority whitelisting, but at the moment, this is not needed for running tests.

avi-kik avatar Aug 21 '19 14:08 avi-kik

The make vendor command is broken if you don't have dep installed in the local directory, and there's no script or instructions for downloading it.

avi-kik avatar Aug 27 '19 11:08 avi-kik

The make vendor command is broken if you don't have dep installed in the local directory, and there's no script or instructions for downloading it.

@avi-kik it's standard go toolchain utility and i thought it's out of the scope of this repo, similar to not having instructions to install pip in a python repo or npm in a node repo. regardless checkout the (very short) docs https://golang.github.io/dep/

oryband avatar Aug 27 '19 11:08 oryband

@avi-kik can you add a review for this PR please?

oryband avatar Aug 27 '19 11:08 oryband