godot-videodecoder icon indicating copy to clipboard operation
godot-videodecoder copied to clipboard

godot_videodecoder_open_file is modifying input_format struct owned by system.

Open ecurtz opened this issue 2 years ago • 1 comments

Although technically it isn't const this is causing a crash on OS X and is probably a bad idea in general. Also the pointer doesn't appear to actually be used after the flags are modified, so it's probably safe to not do this?

https://github.com/kidrigger/godot-videodecoder/blob/af71383dce66eea88f3ce99b416613b925be3ba0/src/gdnative_videodecoder.c#L552

ecurtz avatar Feb 15 '23 00:02 ecurtz

I agree that overriding the output of probe is probably a mistake.

jamie-pate avatar Feb 15 '23 00:02 jamie-pate