feat: moebooru quick fav button

[VALLIS-NERIA]

[khoadng]

The thing holding me back from adding this favorite button to the listing is that all state is lost when you restart the app, which is confusing for users. Moebooru doesn't have a way to check favorite status in batch

[VALLIS-NERIA]

I just pushed another implementation 1 minute ago - The quick fav button hides when the state is not loaded yet.

[khoadng]

The UX for this doesn’t feel great, especially on large screens, and it still makes a lot of unnecessary requests since most posts aren’t favorited.

I think the previous implementation was better. I’m not sure if Moebooru returns a status indicating whether a post has already been favorited. If it does, just show the post in the unfavorited state and notify the user with a toast when user favorite it.

[VALLIS-NERIA]

No, Moebooru returns nothing special when favorating an already favorited post.

IMHO if the buttons can't represent actual favorite status, we should use a different UI to prevent confusing.

Besides, the number of request increases from 1x (1 thumbnail per post) to 2x (thumbnail + fav list). If this still concerns we can introduce some cache mechanism and only pull the latest fav list when opening details page.

[khoadng]

I think we should just keep it simple.

https://github.com/khoadng/Boorusama/blob/303dfe8dbb942fb6371afc3f1cefe435557f8b8a/lib/boorus/gelbooru/configs/create_gelbooru_config_page.dart#L197

Gelbooru has this problem and just showing a warning is enough. Maybe we should change the favorite UX to use an optimistic approach like other Boorus. Moebooru has an oddball implementation right now.

[VALLIS-NERIA]

My idea is a heart icon with an add sign at the corner. When user click it, play the explosion animation only, the filling color remains unchanged.

获取 Outlook for iOShttps://aka.ms/o0ukef

---

发件人: khoadng @.> 发送时间: Monday, February 24, 2025 10:48:59 PM 收件人: khoadng/Boorusama @.> 抄送: @.*** @.>; Author @.> 主题: Re: [khoadng/Boorusama] feat: moebooru quick fav button (PR #514)

I think we should just keep it simple.

https://github.com/khoadng/Boorusama/blob/303dfe8dbb942fb6371afc3f1cefe435557f8b8a/lib/boorus/gelbooru/configs/create_gelbooru_config_page.dart#L197

Gelbooru has this problem and just showing a warning is enough.

― Reply to this email directly, view it on GitHubhttps://github.com/khoadng/Boorusama/pull/514#issuecomment-2678678711, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADE6EERR7OMKUDZ5QDINLFD2RMWNXAVCNFSM6AAAAABXXSGCQKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZYGY3TQNZRGE. You are receiving this because you authored the thread.Message ID: @.***>

[khoadng]khoadng left a comment (khoadng/Boorusama#514)https://github.com/khoadng/Boorusama/pull/514#issuecomment-2678678711

I think we should just keep it simple.

https://github.com/khoadng/Boorusama/blob/303dfe8dbb942fb6371afc3f1cefe435557f8b8a/lib/boorus/gelbooru/configs/create_gelbooru_config_page.dart#L197

Gelbooru has this problem and just showing a warning is enough.

― Reply to this email directly, view it on GitHubhttps://github.com/khoadng/Boorusama/pull/514#issuecomment-2678678711, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADE6EERR7OMKUDZ5QDINLFD2RMWNXAVCNFSM6AAAAABXXSGCQKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZYGY3TQNZRGE. You are receiving this because you authored the thread.Message ID: @.***>

[khoadng]

That sounds good for the listing, but the image viewer still needs to stay as is since users need a way to delete their favorites

[VALLIS-NERIA]

Fav status unknown:

Once fav status is loaded (by entering post detail page or clicking quick fav button):

A setting is added to fetch fav status of all posts (Moebooru only and is turned off by default):

[khoadng]

The setting should be Moebooru specific. Please refer to these file on how to do it. https://github.com/khoadng/Boorusama/blob/62b9ed79a68c3dbe201c06c682c400e37a4e99f8/lib/core/configs/src/create/search.dart https://github.com/khoadng/Boorusama/blob/62b9ed79a68c3dbe201c06c682c400e37a4e99f8/lib/boorus/danbooru/configs/src/create_danbooru_config_page.dart

and let moebooru define their own listing configs https://github.com/khoadng/Boorusama/blob/62b9ed79a68c3dbe201c06c682c400e37a4e99f8/lib/boorus/moebooru/configs/create_moebooru_config_page.dart

The setting should be add to booru config like defaultPreviewImageButtonAction, the listing object can only be used for setting that can be applied for every booru. https://github.com/khoadng/Boorusama/blob/62b9ed79a68c3dbe201c06c682c400e37a4e99f8/lib/core/configs/src/booru_config.dart

[VALLIS-NERIA]

Sorry for late update - I've been busy recently ;_; Updated and rebased to master

[khoadng]

looks good, only need to revert the changes in quick_favorite_button.dart and it is done.

[khoadng]

LGTM

[khoadng]

This is not good, I have to revert this PR. Too many requests.

[VALLIS-NERIA]

fine😟

获取Outlook for Androidhttps://aka.ms/AAb9ysg

---

From: khoadng @.> Sent: Tuesday, May 27, 2025 11:22:53 AM To: khoadng/Boorusama @.> Cc: xiweny @.>; Author @.> Subject: Re: [khoadng/Boorusama] feat: moebooru quick fav button (PR #514)

[https://avatars.githubusercontent.com/u/19619099?s=20&v=4]khoadng left a comment (khoadng/Boorusama#514)https://github.com/khoadng/Boorusama/pull/514#issuecomment-2910986479 Screenshot.2025-05-27.at.10.21.17.png (view on web)https://github.com/user-attachments/assets/22eceb6e-e607-42e6-995f-042d247349a9 This is not good, I have to revert this PR. Too many requests.

— Reply to this email directly, view it on GitHubhttps://github.com/khoadng/Boorusama/pull/514#issuecomment-2910986479, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADE6EEXWAIU5ZDARPWKK2QD3APLA3AVCNFSM6AAAAABXXSGCQKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSMJQHE4DMNBXHE. You are receiving this because you authored the thread.Message ID: @.***>