Kristian Hellang

Results 237 comments of Kristian Hellang

Yeah, that's not what we'd consider a "valid" script. All `using`, `#load` and `#r` should be before the script "body". The code in in question is this: https://github.com/scriptcs/scriptcs/blob/288e7d5c6b3f2e6d4bd91da54a60e1ce8cc07514/src/ScriptCs.Core/FilePreProcessor.cs#L118-L130 As you...

And I think, as far as the console goes, Ctrl+C or Ctrl+Break is our [only (?) option](http://msdn.microsoft.com/en-us/library/system.console.cancelkeypress%28v=vs.110%29.aspx)...

Can't you use the `EnableRewind` functionality on the request for this? That should take care of buffering and potentially spool to a temp file is the body is big enough.

If you only do a partial read (less than the threshold), the bytes never touch disk anyway. You only want the buffering part so you can rewind the stream after...

This is actually a really good suggestion :+1:

> I'm sorry, but this is not correct. You can only use C# 8 language features in a project that targets .NET Core or .NET Standard 2.1. If PP continues...

You've left out quite a bit of information here... What are the dependencies of `MyService`? What are their lifetimes? What's the lifetime of `MyService` itself? Is it scoped? Why are...

> so this seems to be a StructureMap issue? Yeah, that's what I was afraid of. I'm not sure what I can do with this in the adapter. For some...

Hmm. That's really weird. I'll take a look at it when I get home from work. What happens if you set a breakpoint in `ConfigureContainer` and inspect the registry? Does...

I'm not sure what you mean by > As well, if the Scan has the clause `a.Exclude(t -> true);` instead of the `Include(...)` also works the first time. How can...