Kristian Hellang

Results 237 comments of Kristian Hellang

Not really, I've never seen `Assembly.GetEntryAssembly()` return `null` before. I mean; how can you even run an assembly without an entrypoint? 🤔

There hasn't been any attempts at fixing this as I have no clue how to reproduce it. I'm afraid I have to require more information or even better; a pull...

Hi @seangwright! 👋🏻 Yeah, that's just the way it works. It's exactly the same every time you call `AddClasses` 😅 Changing this now would be a major breaking change and...

Hmm... I don't think this is possible currently, but it might be doable. Best case is just changing this line: https://github.com/khellang/Scrutor/blob/5516fe092594c5063f6ab885890b79b2bf91cc24/src/Scrutor/ServiceCollectionExtensions.Decoration.cs#L296 To ```csharp services.Where(service => serviceType.IsAssignableFrom(service.ServiceType)) ``` That could allow...

Hey @DavidRooney! 👋🏻 Sounds reasonable. I'd probably take a PR for this if you're up for it 😄

BTW, the `RegistrationStrategy` class is public, so you're free to extend this however you want, without having an "official" solution.

I'm actually leaning towards calling this a bug in LightInject. `Type` is a perfectly valid extensibility point and there's a way to fix this issue on their side: > It's...

Created a PR at https://github.com/seesharper/LightInject.Microsoft.DependencyInjection/pull/195.