keystone
keystone copied to clipboard
Return ResolvedKeystoneConfig instead of KeystoneConfig
- renamed
__ResolvedKeystoneConfigtoResolvedKeystoneConfig; - Return default config from
configfunction so that any config wrapper can make use of defaults. config()now returnsResolvedKeystoneConfiginstead ofKeystoneConfigwithAuthinput now needsResolvedKeystoneConfig
Breaking changes due to type change, There is no migration needed in most cases instead of type casting in some case.
Changes only needed in advanced use case like manually running the dev/build process instead of
cli
This pull request is automatically built and testable in CodeSandbox.
To see build info of the built libraries, click here or the icon next to each commit SHA.
Latest deployment of this branch, based on commit f5fbd046a00f2e433edfa16ac04d8dbea56046ca:
| Sandbox | Source |
|---|---|
| @keystone-6/sandbox | Configuration |
@gautamsi
Breaking changes due to type change, There is no migration needed in most cases instead of type casting in some case.
Do we actually need to break? The resolved type is only a type refinement, hopefully
we can do minor change for this, as no one was using until now.
@dcousens I have updated this to be minor instead of major change. Also changed base to main. let me know if you need any other changes
@dcousens seems like you spent quiet a bit on this, still need more work to finish this? (and #9204)