keystone icon indicating copy to clipboard operation
keystone copied to clipboard

Return ResolvedKeystoneConfig instead of KeystoneConfig

Open gautamsi opened this issue 1 year ago • 1 comments

  • renamed __ResolvedKeystoneConfig to ResolvedKeystoneConfig;
  • Return default config from config function so that any config wrapper can make use of defaults.
  • config() now returns ResolvedKeystoneConfig instead of KeystoneConfig
  • withAuth input now needs ResolvedKeystoneConfig

Breaking changes due to type change, There is no migration needed in most cases instead of type casting in some case.

Changes only needed in advanced use case like manually running the dev/build process instead of cli

gautamsi avatar Jun 29 '24 06:06 gautamsi

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f5fbd046a00f2e433edfa16ac04d8dbea56046ca:

Sandbox Source
@keystone-6/sandbox Configuration

codesandbox-ci[bot] avatar Jun 29 '24 06:06 codesandbox-ci[bot]

@gautamsi

Breaking changes due to type change, There is no migration needed in most cases instead of type casting in some case.

Do we actually need to break? The resolved type is only a type refinement, hopefully

dcousens avatar Nov 13 '24 03:11 dcousens

we can do minor change for this, as no one was using until now.

gautamsi avatar Nov 15 '24 22:11 gautamsi

@dcousens I have updated this to be minor instead of major change. Also changed base to main. let me know if you need any other changes

gautamsi avatar Dec 02 '24 02:12 gautamsi

@dcousens seems like you spent quiet a bit on this, still need more work to finish this? (and #9204)

gautamsi avatar Jan 20 '25 01:01 gautamsi