keystone icon indicating copy to clipboard operation
keystone copied to clipboard

[POC] for theming

Open gautamsi opened this issue 4 years ago • 6 comments

ref #5106

this only does a poc of how to enable theming with admin ui.

I could make changes to font and colors. This font changes needed custom logo component but we should be able to add a Global style without the need to change the components. image

not sure if this is in immediate roadmap or not but could be useful and does not change anything if devs do not change the code.

gautamsi avatar Mar 12 '21 23:03 gautamsi

⚠️ No Changeset found

Latest commit: 5d6197f671a46a913d843e36ad50a92eb4f8bf9f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Mar 12 '21 23:03 changeset-bot[bot]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/8aNe3gudt2yrZCcC5uUSwHdwmi3Q
✅ Preview: https://keystone-next-git-fork-gautamsi-enable-theme-provider-k-0437c9.vercel.app

vercel[bot] avatar Mar 12 '21 23:03 vercel[bot]

Hey @gautamsi great PR, I wanted to get back to you with some feedback on it.

First up, you're spot on, this is really close to a POC I did a couple of months back when thinking through "how would we want theming to work in the new Admin UI?"

Second, probably the only reason something very similar to this hasn't been shipped yet is that we have very little confidence in the current theme structure or design system. What's there is very much "just enough to build an Admin UI" and we're conscious that opening it up with a first-class API for theming could cause a really difficult upgrade jump down the track.

So I guess that while I'd say "this is probably how we'd do it" I also mean "unless we meaningfully change how theming works, which we may want to when we actually come to focus on it"

If there's enough demand for theming before we get to that part of our roadmap with v6 we could potentially open up an experimental flag to enable it though, now that we have that pattern, so lets see how it goes.

JedWatson avatar Mar 28 '21 22:03 JedWatson

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5d6197f671a46a913d843e36ad50a92eb4f8bf9f:

Sandbox Source
@keystone-next/example-sandbox Configuration

codesandbox-ci[bot] avatar Apr 13 '21 13:04 codesandbox-ci[bot]

@JedWatson Though this is a POC, I feel enabling it as experimental makes a tonne of sense as theming support (however basic it may be) is one of the most common expectations from a framework. So if there's no major issues with this approach, please merge!

zuhair-naqvi avatar Apr 14 '21 22:04 zuhair-naqvi

It looks like there hasn't been any activity here in over 6 months. Sorry about that! We've flagged this issue for special attention. It wil be manually reviewed by maintainers, not automatically closed. If you have any additional information please leave us a comment. It really helps! Thank you for you contribution. :)

stale[bot] avatar Aug 13 '21 23:08 stale[bot]