keystone icon indicating copy to clipboard operation
keystone copied to clipboard

Why the AdminUI supports only email/pass auth strategy?

Open chomamateusz opened this issue 5 years ago • 4 comments

I've added 2 auth strategies: Google and FB, with redirects URL /auth/google and /auth/fb.

Next I've forked the AdminUI, and I've added 2 regular buttons with href to URLs mentioned above.

FBandGoogleLogin

Why this is not allowed by new AdminUIApp constructor? Only thing that UI needs in OAuth auth is the redirect URL for each method (and maybe button props) and it could simply generate this buttons for me.

I've not battle tested it yet, but for now as I'm testing Keystone possibilities, it works like a charm - I can log is through FB and Google.

Is that more complicated than I think? Or simply no one implemented it yet?

chomamateusz avatar Mar 04 '20 17:03 chomamateusz

Why this is not allowed by new AdminUIApp constructor?

We literally just haven't gotten to it yet 😉

Would love to see a PR with some of these enhancements.

One thing to consider is; not every app will want every authentication method. And there may be apps which use a non-core authentication method (for example; I have a custom library which does a hacky passwordless thing that's WIP right now, maybe I want to be able to plug that straight into the Admin UI too).

jesstelford avatar Mar 04 '20 22:03 jesstelford

It looks like there hasn't been any activity here in over 6 months. Sorry about that! We've flagged this issue for special attention. It wil be manually reviewed by maintainers, not automatically closed. If you have any additional information please leave us a comment. It really helps! Thank you for you contribution. :)

stale[bot] avatar Jul 02 '20 22:07 stale[bot]

Does anyone know if this is still the issue for Keystone-next or if its admin supports more auth methods now?

dimaip avatar Mar 19 '21 20:03 dimaip

It looks like there hasn't been any activity here in over 6 months. Sorry about that! We've flagged this issue for special attention. It wil be manually reviewed by maintainers, not automatically closed. If you have any additional information please leave us a comment. It really helps! Thank you for you contribution. :)

stale[bot] avatar Jul 17 '21 23:07 stale[bot]

Please see our discussions on this topic, https://github.com/keystonejs/keystone/discussions?discussions_q=is%3Aopen+authentication and for specific feature requests

dcousens avatar Nov 14 '23 01:11 dcousens