rust-keylime
rust-keylime copied to clipboard
keylime
Update rust-config to 0.15
Thank you for the contribution!
For dependencies updates, we usually rely on dependabot PRs. We also follow kind of a selfish unwritten rule that we do not merge bumps to dependencies for versions that are not available on Fedora.
Fedora has a strict rule that only packaged crates can be used to build other components. If we update dependencies upstream (i.e. here in this repository) to versions that are not available in Fedora, later we have difficulties building our package updates there.
Unfortunately we cannot merge this at the moment. I hope you understand.
This PR is explicitly to unlock the packaging of rust-config 0.15. See https://src.fedoraproject.org/rpms/rust-config/pull-request/4
This PR is explicitly to unlock the packaging of
rust-config 0.15. See https://src.fedoraproject.org/rpms/rust-config/pull-request/4
I see... I believe we have a classic chicken-egg problem here. I will reopen the PR, please rebase it on top of current master.
In future, please be explicit about the intention behind an open PR :smile:
Codecov Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 56.05%. Comparing base (c927924) to head (7360e22).
Additional details and impacted files
| Flag | Coverage Δ | |
|---|---|---|
| e2e-testsuite | 56.05% <ø> (-1.38%) |
:arrow_down: |
| upstream-unit-tests | 56.05% <ø> (-1.38%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more. see 8 files with indirect coverage changes
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
Thanks for the rebase, and sorry I didn't get back to it, it fell off my radar
@LecrisUT I think the change itself is ok, the test that is erroring is probably due to some infra issue in the CI pipeline.
I can approve and merge this if you promise the new version of the config crate will be available in Fedora soon :)
I am packaging the dependency for rust-config. How about I ping you when it is ready to be merged (should be in 2 weeks)
I am packaging the dependency for rust-config. How about I ping you when it is ready to be merged (should be in 2 weeks)
That would be great, thank you!
Well, this fell off my radar entirely. There is a rust-config0.13 compatibility package for all the remaining dependents so it is safe to merge this (was safe to do for 2 months, very sorry that I didn't update you guys here)
https://bodhi.fedoraproject.org/updates/FEDORA-2025-bec1babed4
Well, this fell off my radar entirely. There is a
rust-config0.13compatibility package for all the remaining dependents so it is safe to merge this (was safe to do for 2 months, very sorry that I didn't update you guys here)https://bodhi.fedoraproject.org/updates/FEDORA-2025-bec1babed4
@LecrisUT : May I ask you to try resolving conflicts? I can try doing it myself but, sincerely, I would prefer you to do it if possible