Kevin Wan comments

Results 336 comments of


                                            Kevin Wan

trafficstars

Why the signature of the `hmset` function in `redis` use `map[string]string `instead of `map[string]any` type key-value?

Better to use the same type in the hash key.

fix: bug only processed client, not server.

Please remove unused code to avoid staticcheck errors.

fix: bug only processed client, not server.

Would you please explain why only process client?

fix: bug only processed client, not server.

> > Would you please explain why only process client? > > for response body may large But if the response body is not large, and I want to check...

Goctl RPC Generate Problem

@anqiansong PTAL.

load yaml config file can not recognize purely numeric strings without quotatio

Let me check how to fix it. We designed it like this is because go-zero handles config files in the same way inspite of yaml, json, toml, properties etc.

feat: support multiple extract token key

Would you please give some examples on how to use different token keys? For example, how to request the API with curl.

feat: support multiple extract token key

Bearer is the standard schema, is there any official spec that talks about Bearer replacement?

fix: ensure Dockerfile includes etc directory and correct CMD based on config

## Unit Tests Added for PR #4343 I've reviewed this PR and can confirm it fixes **two real bugs**: 1. **Bug 1**: The etc directory check uses the wrong base...

fix: ensure Dockerfile includes etc directory and correct CMD based on config

## Complete Unit Test File I've created a comprehensive test file (`tools/goctl/docker/docker_test.go`, 376 lines) that covers all scenarios. You can view or download the test file from this gist: https://gist.github.com/kevwan/docker-test-pr4343...