Kevin Wan comments

Results 365 comments of


                                            Kevin Wan

hope to have traceid in sql trace and aliyun database dashboard

Didn't submit details for security reasons. What kind of info you like to submit?

Better loading of configuration

I don't think the change works well for the existing code.

Better loading of configuration

> @kevwan can you explain what is the usage of `optional=CertFile`. > > ```go > CertFile string `json:",optional"` > CertKeyFile string `json:",optional=CertFile"` > CACertFile string `json:",optional=CertFile"` > ``` It means...

Docs and comments are not retained when using goctl to generate code from api file

```go type PingResp { // ACK message // second line Message string `json:"message"` } ``` Not working?

Docs and comments are not retained when using goctl to generate code from api file

@MarkJoyMa @anqiansong PTAL.

ci: add go ci checks, fixed some go vet issues.

> Thanks @kevwan for the PR. I have a question about `gofumpt`. > > Most developers are writing Go code with vscode or goland (myself is using vscode), and `gofumpt`...

ci: add go ci checks, fixed some go vet issues.

Personally, I prefer the stricter one. :) My thinking is that we need to decide which coding style is preferred. For the tool concern, CI will let contributors know how...

ci: add go ci checks, fixed some go vet issues.

> After walking through the code change one by one, I have the following comments, I think some of them are good, and a few are debatable. > > *...

ci: add go ci checks, fixed some go vet issues.

Because `Merge the same type of declaration` is not sure, I removed `-extra` to ignore it.

ci: add go ci checks, fixed some go vet issues.

> Besides the test failure on Windows, I think another issue that blocks the merge of the PR is: can we improve the installation experience of the new tool? The...