Kevin Rushforth

Results 483 comments of Kevin Rushforth
trafficstars

That's a fair point about emitting a warning, since it is likely a mistake. Similarly, if the main method is not `public`, a warning seems a good idea. I would...

> if the launching-without-main-method functionality does get deprecated then a warning should be emitted if the main-class is missing the public static void main(String[]) method, saying something like "main method...

I filed [JDK-8230119](https://bugs.openjdk.java.net/browse/JDK-8230119) in JBS to track this.

Worth noting is that a non-public `static void main(String[])` method is silently ignored today. As I mentioned above, when/if we fix JDK-8230119, I think we should emit a warning in...

This does seem like a bug in JavaFX. Can you file a JBS issue at [bugreport.java.com](https://bugreport.java.com/)?

> The arm-specific qmake arguments I think you mean Cmake (WebKit moved from Qmake to Cmake quite a while ago).

This GitHub issue tracker is not actively tracked or managed. Please file a bug at [bugreport.java.com](https://bugreport.java.com).

I won't be able to get to this right away. If we go this route, a fallback is probably not necessary. One thing of note is that the AWT code,...

I removed myself as a reviewer until this is ready for review (currently it is WIP).

As announced in [this message](https://mail.openjdk.java.net/pipermail/openjfx-dev/2019-September/023551.html), the official `jfx` repository is moving from [hg.openjdk.java.net/openjfx/jfx-dev/rt](https://hg.openjdk.java.net/openjfx/jfx-dev/rt) to [github.com/openjdk/jfx](https://github.com/openjdk/jfx). This [sandbox repository](https://github.com/javafxports/openjdk-jfx) is being retired on 1-Oct-2019. You will need to migrate your WIP...