Kevin Rushforth
Kevin Rushforth
There seems to be insufficient motivation to do this.
> I guess there is no way to reopen pull requests, except creating new ones? There is, using the Skara `/open` command. In this case, I think the approach suggested...
I reopened the JBS bug (it has been closed as "Won't fix" long ago). @johanvos or @jperedadnr can decide whether they want to review and sponsor this.
The API and docs for `ObservableValue::when` look like they are in good shape, so I'll review them next week. My only overall comment is that this PR should be limited...
The update to revert `javafx.graphics` looks good. I'll finish reviewing soon. Can you merge in the latest master? Your PR branch is a couple months out of date, and it...
I am closing this PR now that #1067 is integrated.
> Can you reproduce Kevin's observation at [1f66f61](https://github.com/openjdk/jfx/pull/789/commits/1f66f613ae3ba2ffc553d29424dd5b553d85978a)? If yes, which commit fixed it for you? For me it's the one that changed the order of the fields. Btw, I...
Btw, I am running this on an Intel UHD Graphics 630.
To close the loop on the three problems I reported earlier: > 1. The ambient light doesn't go back to black when an ambient light is added then removed. >...
> > Btw, I can confirm that yes, this fixed it for me. Specifically, commit [55fe2dc](https://github.com/openjdk/jfx/commit/55fe2dc7371f6dcb12c414c5d672728e47e9c504) has resolved my issue. > > If you have time, it would be interesting...