Kevin Burke

You should be able to add a separate file in the same package that has the function definition you want in uppercase, right? Then you wouldn't need to add a...

I’m not sure an API “would be good either way” since an API would have to be maintained for everyone for perpetuity where a single file that fits your use...

I am pretty firmly against adding this - it would add hundreds of new public methods if someone is putting hundreds of files in bindata.go, it's not clear why it...

FWIW, the tests check this by running `cat` on /etc/os-release; I know it's not ideal but it would let you check the image you download or are running. ``` $...

sorry, i'm not really doing python dev any more :( i'm surprised you can set it! i thought the write was non blocking, somehow. ## Kevin Burke 925.271.7005 | kev.inburke.com...

I don't think it's likely to change much, seems fine to me.

from upstream: > `go_resource` are deprecated and are not acceptable in new formulae, please ask upstream to implement go vendoring. Would you be open to vendoring dependencies here?

cc @ChrisHines

Benchmarks also fail to complete: ``` goroutine 15 [running]: panic(0x1a7680, 0xc4200145b0) /Users/kevin/go/src/runtime/panic.go:500 +0x1a1 github.com/inconshreveable/log15.logfmt(0xc420058070, 0xc42002bde8, 0x6, 0x6, 0x0) /Users/kevin/code/go/src/github.com/inconshreveable/log15/format.go:100 +0x128 github.com/inconshreveable/log15.LogfmtFormat.func1(0xc420096000, 0x19a500, 0x576a1401, 0x2db9e8) /Users/kevin/code/go/src/github.com/inconshreveable/log15/format.go:92 +0x2ee github.com/inconshreveable/log15.formatFunc.Format(0x1f1ac0, 0xc420096000, 0x2c1460, 0x3dff7,...

The four benchmarks that ran didn't show much better perf, but they might not be representative :( Master: ``` BenchmarkStreamNoCtx-4 500000 3537 ns/op BenchmarkDiscard-4 2000000 819 ns/op BenchmarkCallerFileHandler-4 1000000 1925...