Kevin Backhouse

Please could somebody try this fix and let me know if it works? https://github.com/Exiv2/exiv2/pull/3359 It's basically a guess, based on the hypothesis that `setlocale` is to blame. I've spent the...

> Also, is that a Windows 10 VM or Windows Server VM? Because standard windows 10 (not server) have winget since build 1809 Windows Server 2022

# crash location I've managed to attach a debugger to this to see what's happening. The crash happens during this line of code: https://github.com/Exiv2/exiv2/blob/d6c67cdd39970795d078bd8ae457af27bf035296/include/exiv2/value.hpp#L1557 It happens while it's printing `*i`,...

I'm able to reproduce it in an `MSYS2 CLANG64` shell with this program: ```c #include int main() { setlocale(LC_ALL, ".UTF-8"); uint16_t x = 15; std::cout

> > Note: that program works fine when compiled with Visual Studio. So it's something to do with the MSYS2 environment. > > The test code [here](https://developercommunity.visualstudio.com/t/setlocale-may-crash-CRT-in-some-cases/10603395) though is supposedly...

Ignore my previous comment. The bug is _also_ reproducible with Visual Studio. The code from the old [bug report](https://developercommunity.visualstudio.com/t/setlocale-may-crash-CRT-in-some-cases/10603395) has a typo (a space character in `"en_US. UTF-8"`). With the...

What's the benefit of using `std::isgreater`? It's more verbose. Also some of these changes look like they would change behavior. For example, replacing `!=` with std::isgreater` doesn't look right.

I see. According to [this document](https://pubs.opengroup.org/onlinepubs/009695399/functions/isgreater.html), `isgreater` behaves exactly the same as `>`, except it will never trigger an exception. I assume the word "exception" here means a `SIGFPE` rather...

@neheb: Please could you revert the changes to the `==` and `!=` operators? I think we should only replace the `>` operator.

I just tried this and it works. The only thing that seems a bit strange is that you can choose either weather or air pollution, but you cannot have both....