Kai-Hsun Chen

Results 306 comments of Kai-Hsun Chen
trafficstars

> Is it safe to remove the Ready state? I imagine a lot of people depend on this status already and it would break compatibility Good point. I suspect that...

> The reality is that many users will not open issues or complain about something even if they use it. @davidxia opening this PR to change the behavior is one...

> Most users that depend on the ready state probably expected it to cover this scenario anyways, so I think changing the current definition of .status.state = ready is actually...

@MortalHappiness will take https://github.com/ray-project/kuberay/pull/1930#pullrequestreview-2044141001.

Thank you for the feedback! I will try to reach out to our CI/Security teams to set it up the DockerHub back, but I think it may be a long...

I ran the following command, and the package seems to exist. ```sh > go list -m github.com/ray-project/kuberay/[email protected] github.com/ray-project/kuberay/ray-operator v1.1.0-rc.0 ```

Both rc.0 and rc.1 exist. I'm not sure why you're unable to get the package locally. * https://sum.golang.org/lookup/github.com/ray-project/kuberay/[email protected] * https://sum.golang.org/lookup/github.com/ray-project/kuberay/[email protected] > @kevin85421 maybe we could have that workflow triggered on...

I will review this PR this week.

> last time we met you expressed some interest about some limitations of current Services and Endpoints, do you think you can provide some steps with existing example to reproduce...

Would you mind rebasing with the master branch? Thanks!