Kai-Hsun Chen
Kai-Hsun Chen
Chatted with @yangwwei offline. We plan to address this issue on v1.3.0.
Hi @yangwwei, thank you for the PR! Are you in the Ray Slack workspace? My Slack handle is "Kai-Hsun Chen (ray team)" We can have a quick sync on Slack...
Hi @yangwwei, I plan to review this PR next week because the REP has already been merged. Is this PR ready for review? I see it is still marked as...
I will review the PR tmr. Thanks!
Could you (1) fix the CI lint error (install the [pre-commit hooks](https://github.com/ray-project/kuberay/blob/master/ray-operator/DEVELOPMENT.md#pre-commit-hooks)) (2) add some instructions about how do you manually test it with Yunikorn in the PR description? I...
Could you fix the lint error? You can refer to this doc to install pre-commit https://github.com/ray-project/kuberay/blob/master/ray-operator/DEVELOPMENT.md
Btw, I hope to include this PR in v1.2.0. I will do the branch cut next week.
I test it manually, and I can see events from `yunikorn` in both head and worker Pods. I am wondering what's the scheduling strategy (e.g. gang scheduling) in this example.
cc @rueian would you mind checking whether we should include this in the scope of v1.4.0?
This is on a critical code path. We should have more testing. Let's discuss it in today's sync.