vcrpy icon indicating copy to clipboard operation
vcrpy copied to clipboard

Ensure body is consumed only once

Open sathieu opened this issue 1 year ago • 3 comments

Fixes: #846

sathieu avatar Jun 27 '24 21:06 sathieu

@hartwork Please take a look at this PR :pray: .

sathieu avatar Jun 30 '24 11:06 sathieu

@sathieu I had a quick look and I think understand the problem now but from a quick look the patch raises questions, may not be the best place to patch yet, and is also lacking a new test to both document and regression-protect the case that it's fixing. I have other priorities at the moment, I won't be able to help more at the moment, thanks for your understanding.

hartwork avatar Jun 30 '24 12:06 hartwork

Thanks @hartwork I've fixed CI and added tests. Back to you :ping_pong: !

sathieu avatar Jul 02 '24 05:07 sathieu

Superseded by just-merged #851, closing…

hartwork avatar Aug 02 '24 17:08 hartwork