react-advanced-form icon indicating copy to clipboard operation
react-advanced-form copied to clipboard

Published 20 hours ago • verified publisher icon kettanaito

TypeScript type definitions

Open kettanaito opened this issue 7 years ago • 4 comments

Introduces a basic typings in TypeScript.

Subjected to merge after a prior discussion.

kettanaito avatar Oct 30 '18 13:10 kettanaito

What do you think about modularizing type definitions, @ell10t?

kettanaito avatar Nov 08 '18 11:11 kettanaito

No objections here, if it makes it more manageable it's probably not a bad idea.

lemcii avatar Nov 12 '18 10:11 lemcii

@ell10t I will try to break it down then.

Apart from that, the only crucial thing that is left is a type definition of that [valuePropName] in various callbacks. Within createField scope it should be possible to do via generics, but I am not sure how to handle it in Form callback methods.

kettanaito avatar Nov 12 '18 11:11 kettanaito

Alright, if I get time I'll have a look into the generics as well.

lemcii avatar Nov 12 '18 11:11 lemcii