Derek Anderson

Results 101 comments of Derek Anderson
trafficstars

hmmmm. i can confirm the behavior. i would note this is comically small language model. that shouldn't be a cause, but you should definitely look to expand the corpus. is...

:+1: but there is clearly a bug here regardless regarding unrecognized words. i'm fine w/ them being split into single-char letters, but that effecting other known words is not OK.

Hmm, the order shouldn't matter because the constraint is dropped before the table. Did it not drop the constraint first? Thanks for reporting! On Mon, Aug 3, 2020, 5:57 PM...

can you resubmit w/o the code reformatting? it's impossible to tell what the change is here.

cool, thanks for the contribution! so you moved two pieces: - create foreign keys - rename tables the latter: ``` for k, v in table_renames.items(): to_run += rename_table(migrator, k, v)...

Glad it's been useful! What database are you hitting? EDIT: NM, I see postgres...

the above change (released in v3.7.4) will stop the error when evolving an unchanged composite key. i've not implemented any logic for evolving composite keys, so going to leave this...

hey @rachetfoot, peewee-db-evolve has never had constraint evolution implemented. (i don't recall it existing when i wrote this - was this new to peewee3?) i'd be all for a PR...

+1 going to leave open tho TODO: implement constraints

thanks! sqlite is tricky, as it doesn't support a number of the normal schema modification SQL commands. (and often requires created a new table, copying data, and deleting the old.)...