keras icon indicating copy to clipboard operation
keras copied to clipboard

implementation of logaddexp in openvino backend (issue #29489)

Open mathys-mt opened this issue 7 months ago • 3 comments

I implemented the numpy logaddexp function in openvino backend using functions already coded in this file. The tests seem to pass, but maybe implementing logaddexp from zero without using the openvino numpy functions would be more effective. @rkazants could you review the PR ?

mathys-mt avatar Apr 27 '25 20:04 mathys-mt

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Apr 27 '25 20:04 google-cla[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.61%. Comparing base (55adc57) to head (433bb34). Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21216      +/-   ##
==========================================
+ Coverage   82.60%   82.61%   +0.01%     
==========================================
  Files         564      564              
  Lines       54404    54454      +50     
  Branches     8460     8467       +7     
==========================================
+ Hits        44938    44986      +48     
- Misses       7391     7395       +4     
+ Partials     2075     2073       -2     
Flag Coverage Δ
keras 82.42% <100.00%> (+0.01%) :arrow_up:
keras-jax 63.74% <0.00%> (-0.01%) :arrow_down:
keras-numpy 58.86% <0.00%> (-0.01%) :arrow_down:
keras-openvino 32.96% <100.00%> (+<0.01%) :arrow_up:
keras-tensorflow 64.14% <0.00%> (-0.01%) :arrow_down:
keras-torch 63.81% <0.00%> (-0.02%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Apr 27 '25 20:04 codecov-commenter

do NOT merge!!!

rkazants avatar Apr 28 '25 06:04 rkazants

This PR is stale because it has been open for 14 days with no activity. It will be closed if no further activity occurs. Thank you.

github-actions[bot] avatar Sep 04 '25 02:09 github-actions[bot]

This was implemented by https://github.com/keras-team/keras/pull/21522

hertschuh avatar Sep 08 '25 21:09 hertschuh