keras icon indicating copy to clipboard operation
keras copied to clipboard

Support numpy.prod operation

Open Xim777 opened this issue 7 months ago • 9 comments

Details

fixes openvinotoolkit/openvino#30212

  • Implements reduce_prod using OpenVINO opset
  • Handles dtype, axis, and keepdims parameters
  • Adds necessary conversion and reduction logic

cc, @rkazants please review 🙏

Xim777 avatar Apr 19 '25 18:04 Xim777

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Apr 19 '25 18:04 google-cla[bot]

Codecov Report

Attention: Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.

Project coverage is 74.19%. Comparing base (dd9132f) to head (a198e04). Report is 107 commits behind head on master.

Files with missing lines Patch % Lines
keras/src/backend/openvino/numpy.py 0.00% 19 Missing :warning:

:exclamation: There is a different number of reports uploaded between BASE (dd9132f) and HEAD (a198e04). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (dd9132f) HEAD (a198e04)
keras 5 3
keras-openvino 1 0
keras-tensorflow 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21188      +/-   ##
==========================================
- Coverage   82.59%   74.19%   -8.40%     
==========================================
  Files         564      564              
  Lines       54407    54426      +19     
  Branches     8449     8453       +4     
==========================================
- Hits        44936    40383    -4553     
- Misses       7396    11971    +4575     
+ Partials     2075     2072       -3     
Flag Coverage Δ
keras 74.05% <0.00%> (-8.36%) :arrow_down:
keras-jax 63.78% <0.00%> (-0.03%) :arrow_down:
keras-numpy 58.90% <0.00%> (-0.03%) :arrow_down:
keras-openvino ?
keras-tensorflow ?
keras-torch 63.87% <0.00%> (-0.03%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Apr 19 '25 18:04 codecov-commenter

Please fix CI failures as well

rkazants avatar Apr 20 '25 12:04 rkazants

I tried running the pytest locally but didn't get any error could guide how to run these test

Xim777 avatar Apr 20 '25 12:04 Xim777

I tried running the pytest locally but didn't get any error could guide how to run these test

Try this & then run pytests export KERAS_BACKEND=openvino

11happy avatar Apr 20 '25 14:04 11happy

I tried running the pytest locally but didn't get any error could guide how to run these test

Try this & then run pytests export KERAS_BACKEND=openvino

thank you it was actually the export issue cause of which the failed test were not showing

Xim777 avatar Apr 20 '25 15:04 Xim777

cc, @rkazants please review

Xim777 avatar Apr 20 '25 15:04 Xim777

there are 2 more CI issues, first you need to sign the CLA aggrement https://cla.developers.google.com/ after run pre-commit to remove the formatting issues, you can follow this https://github.com/keras-team/keras/blob/master/CONTRIBUTING.md

11happy avatar Apr 20 '25 16:04 11happy

Apologies for not following the contribution guidelines initially. I've now applied the required changes as per the project's standards.

cc @rkazants — kindly review when you get a chance. Thank you!

Xim777 avatar Apr 20 '25 18:04 Xim777

This PR is stale because it has been open for 14 days with no activity. It will be closed if no further activity occurs. Thank you.

github-actions[bot] avatar Sep 04 '25 02:09 github-actions[bot]

This was implemented by https://github.com/keras-team/keras/pull/21567

hertschuh avatar Sep 11 '25 18:09 hertschuh