keras icon indicating copy to clipboard operation
keras copied to clipboard

Remote Model Loading/Saving + Docstring Fix

Open VarunS1997 opened this issue 1 year ago • 1 comments

  • Resolved .h5 vs .keras confusion arising from misleading docstring
  • Added functionality to save remote models locally before loading or saving

VarunS1997 avatar Oct 02 '24 08:10 VarunS1997

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 78.81%. Comparing base (dfe8af7) to head (3dcfc57).

Files with missing lines Patch % Lines
keras/src/saving/saving_lib.py 20.00% 2 Missing and 2 partials :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #20317      +/-   ##
==========================================
- Coverage   78.81%   78.81%   -0.01%     
==========================================
  Files         512      512              
  Lines       49056    49061       +5     
  Branches     9033     9035       +2     
==========================================
+ Hits        38664    38665       +1     
- Misses       8528     8530       +2     
- Partials     1864     1866       +2     
Flag Coverage Δ
keras 78.67% <20.00%> (-0.01%) :arrow_down:
keras-jax 62.26% <20.00%> (-0.01%) :arrow_down:
keras-numpy 57.40% <20.00%> (-0.01%) :arrow_down:
keras-tensorflow 63.55% <20.00%> (-0.01%) :arrow_down:
keras-torch 62.25% <20.00%> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Oct 02 '24 08:10 codecov-commenter

Fixed here: https://github.com/keras-team/keras/commit/b3e0b46323618cc1cf56715a9b9cf4baf2918a4b

fchollet avatar Oct 18 '24 23:10 fchollet