keras icon indicating copy to clipboard operation
keras copied to clipboard

Improve "Defaults to" by putting to end of arg in docstring and ensuring backticks have proper spacing

Open SamuelMarks opened this issue 1 year ago • 1 comments

If you prefer I can change all arguments to be how the popular Sphinx documentation generator parser works: https://sphinxcontrib-napoleon.readthedocs.io/en/latest/example_google.html

EDIT - Actually created a separate issue to discuss this #18944

Made much smaller and fewer changes than my previous (similar) PRs to improve chance of merging without controversy :)

SamuelMarks avatar Dec 15 '23 02:12 SamuelMarks

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.38%. Comparing base (1941c30) to head (b470eee).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #18945   +/-   ##
=======================================
  Coverage   78.38%   78.38%           
=======================================
  Files         498      498           
  Lines       45520    45520           
  Branches     8393     8393           
=======================================
  Hits        35679    35679           
  Misses       8102     8102           
  Partials     1739     1739           
Flag Coverage Δ
keras 78.22% <ø> (ø)
keras-jax 62.01% <ø> (ø)
keras-numpy 56.34% <ø> (ø)
keras-tensorflow 63.36% <ø> (ø)
keras-torch 62.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Dec 15 '23 02:12 codecov-commenter

Please rebase the code to follow the latest code structure /keras/src/..

sachinprasadhs avatar May 01 '24 23:05 sachinprasadhs

@sachinprasadhs No problem. Merged and resolved conflicts.

SamuelMarks avatar May 02 '24 04:05 SamuelMarks