keras-nlp icon indicating copy to clipboard operation
keras-nlp copied to clipboard
verified publisher icon keras-team

Add type annotations for TransformerEncoder and TransformerDecoder

Open mattdangerw opened this issue 3 years ago • 6 comments

We would like to use type annotations in KerasNLP. We should add them for the encoder/decoder blocks...

https://github.com/keras-team/keras-nlp/blob/master/keras_nlp/layers/transformer_decoder.py https://github.com/keras-team/keras-nlp/blob/master/keras_nlp/layers/transformer_encoder.py

mattdangerw avatar Feb 08 '22 23:02 mattdangerw

I am familiar with TensorFlow/Keras and the transformer theory and implementations (from the TensorFlow Model Garden). I would like to take this task and will send a PR later.

howl-anderson avatar Feb 13 '22 08:02 howl-anderson

Thank you! Please tag me for review!

mattdangerw avatar Feb 24 '22 04:02 mattdangerw

Hey! Is this issue still open?

Stealth-py avatar Apr 08 '22 23:04 Stealth-py

@howl-anderson are you currently working on this?

mattdangerw avatar Apr 12 '22 02:04 mattdangerw

Yes, I'm still working on it. My city is on lockdown for more than one month because of COVID-19. It makes me have less time for this job. I'm sorry for the slow process. I will work hard for this, hopefully, send a PR within two weeks.

howl-anderson avatar Apr 12 '22 06:04 howl-anderson

Ah, alright. Stay safe!

Stealth-py avatar Apr 12 '22 21:04 Stealth-py