keras-io
keras-io copied to clipboard
keras-team
ShiftViT Example Enhancements
Hi, I have updated the ShiftViT example with links to model & space on Hugging Face Hub. (cc: @merveenoyan )
While working on setting up a demo space for ShiftViT, I came across a few errors while saving and loading the model. I have added fixes for those errors as well as part of this PR.
I have also added a section on Model Inference for the benefit of the users of Keras as I felt that was missing from the example. However, if you feel the section is not needed then do let me know, I'll revert those changes.
Thanks for the PR!
Continuous integration / black (pull_request) Failing after 17s — black
Please fix.
Hi @fchollet , I've fixed this: "Continuous integration / black (pull_request) Failing after 17s — black" I've also removed the generated files and limited the PR to only the Python file now.
Have also added some comments explaining why I made certain changes to the code. Looking forward to your review.
Overall things look good! How many lines of code are that in total? (try to run the
add_examplecommand to see). You might want to make to a bit simpler / shorter to fit within the 300 line limit.
Hi @fchollet the original example itself was > 300 lines (403 lines to be precise). This was called out by the original author while adding the example too as mentioned here
After my current changes, the lines of code has increased to 497. Let me know if this would be okay or a blocker.
Also if you have any suggestions on how the code length can be minimised for the example overall then please do let me know.
Not a blocker, that's ok, we can make an exception. Please add the generated files.
Thanks a lot @fchollet ! Also apologies for the delay at my end. Have updated the PR with generated files now. In case, anything needs to be updated please let me know.
@fchollet would appreciate if this PR could be merged if it looks good to go.
I have another PR with minimal changes that needs a quick review. If that looks good, I can add the generated files for it.
Would be really grateful if you do a quick check for both the PRs whenever you find the time.
Sorry to trouble you again @fchollet. I'm not sure who are the other maintainers for this repository.
But it would be great if you/another maintainer could take a quick look at this PR as well as my other PR. Would be grateful if both can be closed soon if they look good to go.
Hi @shivalikasingh95, thanks for the PR. It looks like @fchollet approved this, and you generated the markdown and notebook files. I'll go ahead and merge. Thanks!
