keras-io icon indicating copy to clipboard operation
keras-io copied to clipboard

Typing Mistake in Documentation of English-to-Spanish translation with a sequence-to-sequence Transformer

Open aryan7781 opened this issue 3 years ago • 0 comments
trafficstars

https://github.com/keras-team/keras-io/blob/c300386a5989a99f1508a068e62436083c48797c/examples/nlp/neural_machine_translation_with_transformer.py#L156

Inputs For Transformers

1. Encoder Inputs - The encoder of Transformer takes in vectorized source sentences the way they are.

2. Decoder Inputs - The decoder of Transformer takes in the vectorized target sentence, till the previous time step.

Error

image Here, encoder_inputs is the target sentence "so far" is wrong. It should be- decoder_inputs is the target_sentence "so far".

aryan7781 avatar Jul 27 '22 06:07 aryan7781