typescript-sdk icon indicating copy to clipboard operation
typescript-sdk copied to clipboard

To start keploy server from typescript sdk for all OS

Open Hermione2408 opened this issue 2 years ago • 7 comments

To start keploy server from typescript sdk for all OS.

feat keploy/keploy#352

Hermione2408 avatar Apr 06 '23 04:04 Hermione2408

@re-Tick Can you please review this PR?

Hermione2408 avatar Apr 07 '23 03:04 Hermione2408

When I try the changes with a sample application, the following error is thrown:

Error checking port: Command failed: lsof -i:6789

re-Tick avatar Apr 07 '23 06:04 re-Tick

I am checking why it is happening

Hermione2408 avatar Apr 07 '23 07:04 Hermione2408

@re-Tick error is occurring because when there is nothing running on port 6789 , empty output is treated as an error and hence the error is shown, I have added additional check for the error code and will also start the server in that case too

Hermione2408 avatar Apr 07 '23 09:04 Hermione2408

@Hermione2408 changes are working locally. LGTM.

re-Tick avatar Apr 10 '23 13:04 re-Tick