typescript-sdk icon indicating copy to clipboard operation
typescript-sdk copied to clipboard

Published 20 hours ago • verified publisher icon keploy

fix(sdk build, package.json): Added .proto file as a part of build files and used it in grpc connection.

Open Hermione2408 opened this issue 2 years ago • 9 comments

Previously we were using cp command to copy services.proto file from proto folder to dist folder but cp command doesnt work for windows and hence the build fails in windows. I added "copy-files" script which uses copyfiles npm module to copy proto file and is OS independent.

fix keploy/keploy#372

Hermione2408 avatar Mar 01 '23 14:03 Hermione2408

Hi @Hermione2408, Please git rebase to pass DCO. You can follow the 3 steps mentioned in the failing DCO job

re-Tick avatar Mar 01 '23 16:03 re-Tick

I think that we should include .proto file in our "files" of package.json to include them in the npm build files. Screenshot 2023-03-01 at 10 19 10 PM Reference

And use relative path to that for grpcClient connection.

re-Tick avatar Mar 01 '23 16:03 re-Tick

@re-Tick I have updated the PR with the changes Please review it and let me know if this need any changes.

Hermione2408 avatar Mar 01 '23 19:03 Hermione2408

Hi @Hermione2408, Can we use the same "services.proto" file from photo directory instead of new "grpc.proto".

re-Tick avatar Mar 02 '23 07:03 re-Tick

Hey @re-Tick do you mean something like this?

Hermione2408 avatar Mar 02 '23 20:03 Hermione2408

Yes @Hermione2408. Have you built and tested your changes locally? LGTM. Please add the link to the PR in GSOC/2023 task list of typescript-sdk project.

re-Tick avatar Mar 03 '23 06:03 re-Tick

Yes I have built and tested my changes locally ,Its working fine.

Hermione2408 avatar Mar 03 '23 06:03 Hermione2408